[PATCH] D67126: [GVN/FP] Considate logic for reasoning about equality vs equivalance for floats

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM.  Could you add a TODO to handle vector constants? It seems this is used on code paths that would also see vector fcmps, so it would be good to address this as follow up.

Please wait a few days with committing, in case @scanon  or anyone else has any additional feedback.



================
Comment at: test/Transforms/GVN/edge.ll:96
 
+define double @fcmp_one_possibly_nan(double %x, double %y) {
+entry:
----------------
Could you add a few additional tests for ueq?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67126/new/

https://reviews.llvm.org/D67126