[PATCH] D71032: [AIX] Make sure to use QualNames for external global objects
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 5 10:05:34 PST 2019
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1888
+ if (!XSym->hasContainingCsect()) {
+ // Make sure the storage class is set.
+ const XCOFF::StorageClass SC =
----------------
How do we know that having the containing csect set is enough to know that the storage class has been set? Should we have an assume after the `if` block that the storage class is set? Or perhaps a comment that the containing csect could not have been set without the storage class being set on the symbol.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71032/new/
https://reviews.llvm.org/D71032
More information about the llvm-commits
mailing list