[PATCH] D70986: [DDG] Data Dependence Graph - Ordinals

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

I do not understand why the ordinals are necessary. For deterministic behavior, the deterministic iteration order over blocks and instructions should already ensure that (unless you are iterating over DenseMaps, which does not seem the case and is easily fixed). If for correctness, do you have an illustrative example when this would be critical?



================
Comment at: llvm/lib/Analysis/DependenceGraphBuilder.cpp:57
       IMap.insert(std::make_pair(&I, &NewNode));
+      NodeOrdinalMap.insert(std::make_pair(&NewNode, getOrdinal(I)));
       ++TotalFineGrainedNodes;
----------------
Did you consider string the node ordinal in the Node directly instead of using a lookup table?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70986/new/

https://reviews.llvm.org/D70986