[PATCH] D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking

[Jeremy Morse via Phabricator via llvm-commits]

jmorse marked 2 inline comments as done.
jmorse added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:381
 
+  // Re-insert any DBG_VALUEs sunk
+  for (auto &Iterator : SunkDebugDefs) {
----------------
bjope wrote:
> My only comment is that you might consider breaking out the new code added here to a function/method before committing.
> 
> For example
> 
> ```
> void MachineSinking::reinsertSunkDebugDefs(MachineFunction &MF) {
>   ...
> }
> ```
> 
> (always nice to keep the runOnMachineFunction relatively small, outlining the overall steps performed in the pass)
Shoehorned that in, cheers!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70676/new/

https://reviews.llvm.org/D70676