[PATCH] D70859: [XCOFF] fixed a bug of XCOFFObjectFile.cpp and adding new test case to verify one mergeable string for xcoffobjectfile
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 5 09:14:26 PST 2019
jasonliu added a comment.
I agree with David about splitting. There are 4 issues mentioned in this patch, and they are not related. (I'm not sure if 1 or 3 could be combine or not)
Putting them together makes it hard to review, and hard to determine if the test case actually covered the issue that's raised.
Let's make separate patches if possible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70859/new/
https://reviews.llvm.org/D70859
More information about the llvm-commits
mailing list