[PATCH] D70889: [AArch64][SVE] Implement integer compare intrinsics
Cullen Rhodes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 5 08:28:12 PST 2019
c-rhodes added a comment.
In D70889#1769773 <https://reviews.llvm.org/D70889#1769773>, @efriedma wrote:
> No testcases for the "IR" (setcc) patterns?
Good spot, so for the signed and unsigned immediate variants (defined with `sve_int_scmp_vi`, `sve_int_ucmp_vi`) there are IR tests in `sve-intrinsics-int-compares-with-imm.ll` but it seems I missed a separate test we have downstream covering the non-immediate forms (defined with `sve_int_cmp_0`). I tried pulling that test in but it looks like it's failing for a number of reasons I don't entirely understand just yet. I think for this patch I'll remove the IR patterns for the non-immediate forms and in the meantime see what's required there for a follow-up patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70889/new/
https://reviews.llvm.org/D70889
More information about the llvm-commits
mailing list