[PATCH] D70496: [AArch64] Fix issues with large arrays on stack
Francesco Petrogalli via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 5 07:40:01 PST 2019
fpetrogalli added a comment.
In D70496#1770739 <https://reviews.llvm.org/D70496#1770739>, @fpetrogalli wrote:
> In D70496#1770521 <https://reviews.llvm.org/D70496#1770521>, @kiranchandramohan wrote:
>
> >
>
>
>
>
> > @fpetrogalli are you OK with the changes I made to your suggestions? Might need some handholding to land this patch.
>
> I am happy, with a nit: I think that `CHECK-COUNT-128` is ignored? Or is `COUNT-128` a specific token for the `CHECK` prefix?
Oh, I didn't know about this: https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-count-directive
The patch LGTM. Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70496/new/
https://reviews.llvm.org/D70496
More information about the llvm-commits
mailing list