[PATCH] D68803: [LNT] Python 3 support: sort benchmark regressing
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 5 07:30:24 PST 2019
thopre added inline comments.
================
Comment at: tests/server/ui/change_processing.py:214-215
r2 = rebuild_title(session, ts_db, self.regression)
- expected_title = "Regression of 6 benchmarks: foo, bar"
+ expected_title = "Regression of 6 benchmarks: bar, foo"
self.assertEquals(r2.title, expected_title)
----------------
PrzemekWirkus wrote:
> I would still add a comment here that "bar, foo" should be in alphabetical order to mach assert with sorted().
Good point.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68803/new/
https://reviews.llvm.org/D68803
More information about the llvm-commits
mailing list