[PATCH] D70460: export.sh: Fetch sources from GitHub instead of SVN

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: llvm/utils/release/export.sh:58
+        echo "Creating tarball for $proj ..."
+        mv $llvm_src_dir/$proj{,-$release$rc.src}
+        tar -C $llvm_src_dir -cJf $proj-$release$rc.src.tar.xz $proj-$release$rc.src
----------------
tstellar wrote:
> tstellar wrote:
> > hans wrote:
> > > It looks like there's only one argument to the mv command. Or is there some bash magic here that makes it work?
> > This expands to:
> > 
> >  mv $llvm_src_dir/$pro j      $llvm_src_dir/$proj -$release$rc.src
> I can change it if you think it makes it more readable.
Yes please, even if the expansion is cool (and I want to learn more about these), I think the explicit version is better for readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70460/new/

https://reviews.llvm.org/D70460