[PATCH] D68803: [LNT] Python 3 support: sort benchmark regressing

Przemyslaw Wirkus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 5 07:16:25 PST 2019


PrzemekWirkus accepted this revision.
PrzemekWirkus added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tests/server/ui/change_processing.py:214-215
 
         r2 = rebuild_title(session, ts_db, self.regression)
-        expected_title = "Regression of 6 benchmarks: foo, bar"
+        expected_title = "Regression of 6 benchmarks: bar, foo"
         self.assertEquals(r2.title, expected_title)
----------------
I would still add a comment here that "bar, foo" should be in alphabetical order to mach assert with sorted().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68803/new/

https://reviews.llvm.org/D68803





More information about the llvm-commits mailing list