[PATCH] D71047: [LV] Keep dominator tree up to date during vectorization.

[Evgeniy via Phabricator via llvm-commits]

ebrevnov marked 2 inline comments as done.
ebrevnov added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:2698
+  LoopVectorPreHeader =
+      OrigPreHeader->splitBasicBlock(OrigPreHeader->getTerminator(), OrigName);
   // Update dominator tree immediately if the generated block is a
----------------
fhahn wrote:
> Please use SplitBlock from BasicBlockUtils.h and pass the DT instead of updating it manually (here and at other paces in the patch) Same for LoopInfo.
I tried to use it but something was not working for me initially. I'll give it another try since I believe that was simply my mistake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71047/new/

https://reviews.llvm.org/D71047