[PATCH] D70930: [llvm-objcopy][WebAssembly] Initial support for wasm in llvm-objcopy
    Alexander Shaposhnikov via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Dec  5 02:30:25 PST 2019
    
    
  
alexshap added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/wasm/Object.h:1
+//===- Object.h -------------------------------------------------*- C++ -*-===//
+//
----------------
I'd prefer to follow the structure which we use for other formats (MachO, COFF, ELF), i.e. put the description of the model into Object.h/Object.cpp (the class Object etc), and put the classes Reader and Writer into separate files, even if they are small at the moment, they might grow in the future, it makes things a little bit easier to read. 
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70930/new/
https://reviews.llvm.org/D70930
    
    
More information about the llvm-commits
mailing list