[PATCH] D69998: [MacroFusion] Create the missing artificial edges if there are more than 2 SU fused.

qshanz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 4 18:24:20 PST 2019


steven.zhang added a comment.

In D69998#1768588 <https://reviews.llvm.org/D69998#1768588>, @fhahn wrote:

> With rGd84b320dfd0a7dbedacc287ede5e5bc4c0f113ba <https://reviews.llvm.org/rGd84b320dfd0a7dbedacc287ede5e5bc4c0f113ba> landed, is this still relevant?


Yes, they are different problems. rGd84b320dfd0a7dbedacc287ede5e5bc4c0f113ba <https://reviews.llvm.org/rGd84b320dfd0a7dbedacc287ede5e5bc4c0f113ba> is trying to limit the number of chained SU's as two, while this patch is to fix the problem if we want to chain more than two SU's, though it is limited to two now. But by the design, we should have it work well if someone want to relax the limit later. It is somewhat like, we have the ability to chain any number of SU's, but now, it is limited to two, instead of, we can only chain two SU's, and have bugs if chain more.

There won't be any compiling time impact for this patch if it is limited to two, as the pred/succ of CurrentSU is always null if only chain two SU's.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69998/new/

https://reviews.llvm.org/D69998





More information about the llvm-commits mailing list