[PATCH] D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:7228
+      // to move the dbg.value.
+      if (VI && DT.dominates(VI, DVI))
+        continue;
----------------
Is this expensive?


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:7231
+
+      if (VI && !VI->isTerminator()) {
         // If VI is a phi in a block with an EHPad terminator, we can't insert
----------------
continue, too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58453/new/

https://reviews.llvm.org/D58453