[PATCH] D71032: [AIX] Make sure to use QualNames for external global objects

Wed Dec 4 15:54:58 PST 2019

hubert.reinterpretcast added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll:31

+define void @bar2() {
+  store i32 0, i32* @a, align 4
----------------
This needs a comment to explain why a second function is useful for the test. The fact that this tests for a bug that need not have existed is non-obvious.

================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll:85
 ; SYM-NEXT:    Name: a
-; SYM-NEXT:    Value (RelocatableAddress): 0x54
+; SYM-NEXT:    Value (RelocatableAddress): 0x8C
 ; SYM-NEXT:    Section: .data
----------------
It is possible to use an expression here that is based on the value observed for the TOC base? Similarly for the lines below.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71032/new/

https://reviews.llvm.org/D71032