[PATCH] D71008: [DebugInfo] Refactored macro related generation, added a test case for macinfo.dwo emission.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Sorry, I'm a bit confused - this sort of thing should be included in the original review.

But I think this whole direction (supporting macinfo.dwo) should not be done, since macinfo is not in DWARFv5 - so to reach DWARFv5 support, you/we/someone should first fix the existing bug (which is that debug_macro should be emitted in DWARFv5, but currently LLVM produces debug_macinfo instead). and then that correct support can be expanded to support Split DWARFv5.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71008/new/

https://reviews.llvm.org/D71008