[PATCH] D70007: [Intrinsic] Add fixed point division intrinsics.

Leonard Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 4 14:10:36 PST 2019


leonardchan added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:7164
+    SDValue Zero = DAG.getConstant(0, dl, VT);
+    SDValue RemZero = DAG.getSetCC(dl, BoolVT, Rem, Zero, ISD::SETEQ);
+    SDValue QuotNeg = DAG.getSetCC(dl, BoolVT, Quot, Zero, ISD::SETLT);
----------------
Ah, I think you want this to instead be `ISD::SETNE` and `RemNonZero` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70007/new/

https://reviews.llvm.org/D70007





More information about the llvm-commits mailing list