[PATCH] D70709: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part.

Wed Dec 4 13:34:34 PST 2019

JDevlieghere added a comment.

In D70709#1769569 <https://reviews.llvm.org/D70709#1769569>, @avl wrote:

> > The modules build is good because it's kind of a special case, but I'd like to check a clang without modules as well. I'm a little confused by LLVM_USE_SPLIT_DWARF though, as that's not something that makes sense on macOS unless it's a NO-OP?
>
> right. LLVM_USE_SPLIT_DWARF would be NO-OP on macOS, I used it mistakenly.  Following is the result for clang build without modules:
>
> golden-dsymutil/dsymutil build-Debug/bin/clang
>  md5 -r build-Debug/bin/clang.dSYM/Contents/Resources/DWARF/clang
>  a31430a6a2fbbd81fbed88888c769213 build-Debug/bin/clang.dSYM/Contents/Resources/DWARF/clang
>
> new-dsymutil/dsymutil build-Debug/bin/clang
>  md5 -r build-Debug/bin/clang.dSYM/Contents/Resources/DWARF/clang
>  a31430a6a2fbbd81fbed88888c769213 build-Debug/bin/clang.dSYM/Contents/Resources/DWARF/clang

Great, thank you for checking!

>> Regarding the patch itself, I haven't had a look yet as there's a lot going on. Would it be possible to split this patch into the four main pieces you describe in the summary? I think that would make reviewing a lot easier.
> 
> Actually main changes are in DwarfLinker and DwarfOptimizer. These are closely coupled and could not be done separately. But DwarfEmitter and AddressMap could be done as separate patches. It would not actually decrease the main portion too much. But yes it would be possible and I would start from those split patches then. Thank you.

Cool, much appreciated!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70709/new/

https://reviews.llvm.org/D70709