[PATCH] D67572: [VectorUtils] Introduce the Vector Function Database (VFDatabase).

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:119-121
+  std::string ScalarName; // Scalar Function Name.
+  std::string VectorName; // Vector Function Name associated to this VFInfo.
+  VFISAKind ISA;          // Instruction Set Architecture.
----------------
Use `\\\` style of comment here


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:169
 
+/// \brief The Vector Function Database.
+///
----------------
No need for `\brief`


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:195
+    VFABI::getVectorVariantNames(CI, ListOfStrings);
+    for (auto MangledName : ListOfStrings) {
+      const Optional<VFInfo> Shape = VFABI::tryDemangleForVFABI(MangledName);
----------------
`const auto &`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67572/new/

https://reviews.llvm.org/D67572