[PATCH] D70916: [NFC] Introduce and use DAG.getPointerAdd()

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

This looks like a good change to me, but I think we should split it into smaller patches to reduce risk. 
Since getMemBasePlusOffset() takes an "unsigned", it should be safe to modify that to take an int64_t, right? So something like this:

1. Change getMemBasePlusOffset to take int64_t.
2. (Optionally) change the name/signature - I don't have a strong preference on this, but the SDLoc param should remain "const SDLoc &DL" because that was intentionally changed to a reference for efficiency.
3. Add uses for the form that takes a int64_t.
4. Add the variant that takes an "SDValue Offset" and convert existing code to use it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70916/new/

https://reviews.llvm.org/D70916