[PATCH] D70759: [llvm-symbolizer] Support debug file lookup using build ID

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/Symbolize/Symbolize.cpp:328
+    sys::path::append(Path, ".build-id",
+                      llvm::toHex(BuildID[0], /*LowerCase*/ true),
+                      llvm::toHex(BuildID.slice(1), /*LowerCase*/ true));
----------------
Super nit: `/*LowerCase=*/` may be more common. At least clang-format recognizes this form and deletes the space before `true`.


================
Comment at: llvm/test/DebugInfo/symbolize-build-id.test:1
+# RUN: yaml2obj %s > %t
+
----------------
In binary utilities tests, we use `-o` to avoid shell redirection.


================
Comment at: llvm/test/DebugInfo/symbolize-build-id.test:15
+FileHeader:
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
----------------
`Machine:` is the longest key. The indentation of values can be reduced to the minimum.

`Machine: EM_X86_64`



================
Comment at: llvm/test/DebugInfo/symbolize-build-id.test:23
+    Flags:           [ SHF_ALLOC ]
+    Content:         040000000800000003000000474e5500abb50d82b6bdc861
+ProgramHeaders:
----------------
ditto. `Content: 040000000800000003000000474e5500abb50d82b6bdc861`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70759/new/

https://reviews.llvm.org/D70759