[PATCH] D70513: [VectorUtils] API for VFShape, update VFInfo.

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added inline comments.


================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:1189
+       ++Pos) {
+    if (Parameters[Pos].ParamPos != Pos)
+      return false;
----------------
sdesmalen wrote:
> should this be an assert?
I have updated also the tests replacing EXPECT_FALSE with EXPECT_DEATH, to make sure the assert is not removed.


================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:1222
+      // internal).
+      if (Parameters[Pos].ParamPos != NumParams - 1)
+        return false;
----------------
sdesmalen wrote:
> Can you add a function here that calculates this, per supported VFABI?
Marking this as done as the most recent version of the patch doesn't have any concept for VFABI for GlobalPredicate, as the global predicate is allowed to be anywhere in the signature, as long as it is unique.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70513/new/

https://reviews.llvm.org/D70513