[PATCH] D70030: [MachineBlockPlacement] Update UnscheduledPredecessors when tail duplicate delete a block.

[Guozhi Wei via Phabricator via llvm-commits]

Carrot added a comment.

In D70030#1767393 <https://reviews.llvm.org/D70030#1767393>, @huihuiz wrote:

> Hey @Carrot , really appreciated your time on it.
>
> For the test case provided, I am pretty sure inner loop and outer loop are in different Loop Chain.


This is correct. I already mentioned it in Nov 15. Thanks for the test case.

> From your comments, I still don't understand are there any problems/concerns with the fix proposed?
>  Are you suggesting merging the proposed fix into loop Line:2982? But that's not very clear, I would prefer to have a separate logic.

The main problem is the fix should be applied to all duplication even if BB is not removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70030/new/

https://reviews.llvm.org/D70030