[PATCH] D70961: [LLD][ELF] add support for PT_GNU_PROPERTY

Wed Dec 4 09:41:58 PST 2019

MaskRay added inline comments.

================
Comment at: lld/test/ELF/aarch64-pt-gnu-property.s:1
+# REQUIRES: aarch64
+# RUN: llvm-mc -filetype=obj -triple=aarch64-linux-gnu %s -o %t.o
----------------
peter.smith wrote:
> MaskRay wrote:
> > grimar wrote:
> > > I think you can use x86 for this test.
> > Eventually we may need both. I think we also need a similar x86-64-pt-gnu-property.s. 
> I've changed to use x86. I think the benefit of having both x86 and aarch64 is marginal right now if we are just testing that PT_GNU_PROPERTY describes the range of .note.gnu.property. I can add a new one if preferred.
If you think x86 is sufficient, I am fine with it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70961/new/

https://reviews.llvm.org/D70961