[PATCH] D69048: [LNT] Python 3 support: run tests with UTF-8 encoding

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

In D69048#1768965 <https://reviews.llvm.org/D69048#1768965>, @thopre wrote:

> I can't quite remember but I think the problem is that lit starts from a clean environment to have consistent output (if using the user's environment error message might vary accross systems which would fail lots of tests). AFAIK LNT doesn't have localized error message but it fails to run if the locale is not UTF-8 (or perhaps any unicode locale).


That's my understanding regarding LNT as well; however, the "clean environment" seems to be what is being adjusted here based on the user's environment. My suggestion is to trust the user's environment by passing it through verbatim (since the patch already trusts the user if the locale name ends with `.UTF-8`). The user has to specify an appropriate environment anyway when running LNT outside of tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69048/new/

https://reviews.llvm.org/D69048