[PATCH] D70126: [PowerPC] Refactor FinishCall [NFC]

Zarko Todorovski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 4 07:21:32 PST 2019


ZarkoCA accepted this revision.
ZarkoCA added a comment.
This revision is now accepted and ready to land.

Patch looks good to me.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5363
+            isa<ConstantSDNode>(Callee)) &&
+           "Expecting an global address, external symbol, absolute value or "
+           "register");
----------------
I don't think you wrote the original comment but maybe we can correct: "Expecting a" instead of "Expecting an"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70126/new/

https://reviews.llvm.org/D70126





More information about the llvm-commits mailing list