[PATCH] D70456: [Matrix] Add first set of matrix intrinsics and initial lowering pass.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:49
+// stride between the end of a column and the start of the next one.
+Value *computeEltAddr(Value *MatrixPtr, Value *Row, Value *Col, Type *EltType,
+                      Value *Offset, IRBuilder<> &Builder) {
----------------
Gerolf wrote:
> Do you need this function? Why are Row,Col Value here vs unsigned in the caller (computeColumnAddr())?
Not really. I folded the relevant bits into computeColumnAddr and removed the obsolete Row argument. Also turned the Col argument into a Value *.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70456/new/

https://reviews.llvm.org/D70456