[PATCH] D68408: [InstCombine] Negator - sink sinkable negations

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri updated this revision to Diff 232090.
lebedev.ri marked 10 inline comments as done.
lebedev.ri added a comment.

In D68408#1767626 <https://reviews.llvm.org/D68408#1767626>, @spatel wrote:

> @efriedma - do you want to continue reviewing?




In D68408#1767626 <https://reviews.llvm.org/D68408#1767626>, @spatel wrote:

> I've just pointed out a few nits for now.


Nits addressed.

There are some more patterns that aren't handled here.
The idea is to ideally move them all here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68408/new/

https://reviews.llvm.org/D68408

Files:
  llvm/lib/Transforms/InstCombine/CMakeLists.txt
  llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
  llvm/lib/Transforms/InstCombine/InstCombineInternal.h
  llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp
  llvm/test/Transforms/InstCombine/mul.ll
  llvm/test/Transforms/InstCombine/sub-of-negatible.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68408.232090.patch
Type: text/x-patch
Size: 18140 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191204/d2a1bc7b/attachment.bin>