[PATCH] D70959: [ELF] Support for PT_GNU_PROPERTY in program headers and tools

Wed Dec 4 01:58:37 PST 2019

peter.smith added a comment.

In D70959#1768439 <https://reviews.llvm.org/D70959#1768439>, @jhenderson wrote:

> LGTM, with @MaskRay's comment addressed (I don't mind if the comment is deleted, or kept, but it should at least be fixed).
>
> On the LLD side, I'm assuming that LLD needs to emit it because the kernel in question doesn't parse the PT_NOTE segment for this section? It seems a bit superfluous otherwise...

Thanks I'll remove the comments. Yes the linux kernel does not parse the PT_NOTE section. This is also true for intel CET, https://bugzilla.redhat.com/show_bug.cgi?id=1721606

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70959/new/

https://reviews.llvm.org/D70959