[PATCH] D70956: [yaml2obj] - Make DynamicSymbols to be Optional<> too.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/symtab-implicit-sections-size-content.yaml:30
 # RUN: not yaml2obj --docnum=2 %s -o %t2 2>&1 | FileCheck %s --check-prefix=CASE2
+# RUN: not yaml2obj --docnum=3 %s -o %t2 2>&1 | FileCheck %s --check-prefix=CASE2
 
----------------
jhenderson wrote:
> It probably doesn't matter much, but do the changes in this test belong with this patch?
It is related to changes done in ELFEmitter.cpp: both "Symbols"
and "DynamicSymbols" are handled in the same way now.

Without those changes, this test would fail:
The code without this patch would allow both `Size` and `Symbols []`,
just like it allowed `Size` + `DynamicSymbols: []`.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70956/new/

https://reviews.llvm.org/D70956