[PATCH] D70665: [llvm-readobj] - Implement --dependent-lib-directives flag.

Wed Dec 4 00:26:33 PST 2019

grimar marked 2 inline comments as done.
grimar added inline comments.

================
Comment at: llvm/docs/CommandGuide/llvm-readobj.rst:157
+
+ Display the dependent libraries section.
+
----------------
grimar wrote:
> MaskRay wrote:
> > jhenderson wrote:
> > > section -> directives (in case it starts getting used by COFF)
> > @bd1976llvm @jhenderson Do we have to call it `-directives`? A `#pragma` is referred to as a directive, but the section is not.
> > 
> > We support other options that dump extension sections (e.g. `--stack-sizes`). None has the suffix `-directives`. I think `--dependent-libs` (I presume you will prefer the plural form) should be fine.
> > section -> directives (in case it starts getting used by COFF)
> 
> The section type is called "SHT_LLVM_DEPENDENT_LIBRARIES". That is why I haven't changed the description.
> Given this the description seems to be fine?
Or.. Does "SHT_LLVM_DEPENDENT_LIBRARIES" used by COFF somehow or this section type is needed only for ELF?
(I know nothing about COFF. I've supposed it still creates a section of this type under hood, but may be I getting it wrong?).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70665/new/

https://reviews.llvm.org/D70665