[PATCH] D70800: Fix AArch64 AAPCS frame record chain

[Logan Chien via Phabricator via llvm-commits]

logan marked 5 inline comments as done.
logan added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:2068
+         (IsTargetWindows &&
+          RPI.Reg1 == AArch64::FP && RPI.Reg2 == AArch64::LR)))
+      AFI->setCalleeSaveBaseToFrameRecordOffset(Offset);
----------------
Just noticed that Windows have different ordering.


================
Comment at: llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h:129
 
+  // Offset from SP-at-entry to frame record (i.e. the spilled frame pointer
+  // and link address).
----------------
sdesmalen wrote:
> logan wrote:
> > sdesmalen wrote:
> > > Is this description correct? The current meaning of `FrameRecordOffset` seems to be the offset from SP _after_ allocating the callee-save area.
> > Thanks.  Reworded.
> Thanks! Is it worth renaming the variable to something like `OffsetToFrameRecordFromCalleeSaveBase` to make the meaning of the variable easier to understand in the places it is used? (I couldn't think of something shorter :))
The naming convention in the file seems to be `{get,set,}XXXOffset`, thus I renamed this to `CalleeSaveBaseToFrameRecordOffset`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70800/new/

https://reviews.llvm.org/D70800