[PATCH] D70724: [PowerPC] Add Support for indirect calls on AIX.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

@sfertile, the current diff is missing the tests.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:3157
+  if (Subtarget.isAIXABI())
+    report_fatal_error("ADJUST_TRAMPOLINE operation not supported on AIX.");
+
----------------
Nit: Add "is" before "not" here and on the next change.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5256
+  assert((!hasNest || !Subtarget.isAIXABI()) &&
+         "Nest parameter not supported on AIX");
   if (!hasNest) {
----------------
Nit: Add "is" before "not". Add a period.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5288
+
+    // For the TOC based ABIs we have saved the TOC pointer to the linkage area
+    // on the stack (this would have been done in `LowerCall_64SVR4` or
----------------
Nit: Add a comma after "ABIs".


================
Comment at: llvm/lib/Target/PowerPC/PPCSubtarget.h:363
+    assert(usesFunctionDescriptors() &&
+           "should only be called when target uses descriptors.");
+    return IsPPC64 ? 8 : 4;
----------------
Nit: Capitalize "should". Add "the" before "target". Same for the other cases below.


================
Comment at: llvm/lib/Target/PowerPC/PPCSubtarget.h:381
+    assert((is64BitELFABI() || isAIXABI()) &&
+           "should only be called when target is TOC based ABI.");
+    return IsPPC64 ? PPC::X2 : PPC::R2;
----------------
Nit: Add "a" before "TOC".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70724/new/

https://reviews.llvm.org/D70724