[PATCH] D70752: LowerDbgDeclare: look through bitcasts.
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 3 16:47:00 PST 2019
aprantl added a comment.
In D70752#1768006 <https://reviews.llvm.org/D70752#1768006>, @eugenis wrote:
> I also find worklist a more common and recognizable pattern, but I don't mind recursion either.
It's not that the worklist is terribly complicated to understand either, but when I see a worklist I'm expecting a tricky algorithm that couldn't be implemented with recursion and then need to stop and spend some time that it's really doing something simple. Not a big deal though. In the grand scheme of things both approaches are fine. The recursion has the advantage that we can give the helper function a descriptive name.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70752/new/
https://reviews.llvm.org/D70752
More information about the llvm-commits
mailing list