[PATCH] D70967: [AArch64][SVE] Implement element count intrinsics

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:937
+    : Intrinsic<[llvm_i64_ty],
+                [LLVMScalarOrSameVectorWidth<0, llvm_i1_ty>,
+                 llvm_anyvector_ty],
----------------
What is `LLVMScalarOrSameVectorWidth<0, llvm_i1_ty>` supposed to do here?  Why not just LLVMMatchType?


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-counting-elems.ll:11
+; CHECK-NEXT: ret
+  %out = call i64 @llvm.aarch64.sve.cntb(i32 2)
+  ret i64 %out
----------------
No operand for the MUL immediate?  I guess you could try to pattern-match it, but that seems less reliable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70967/new/

https://reviews.llvm.org/D70967