[PATCH] D70709: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part.

Tue Dec 3 15:51:36 PST 2019

JDevlieghere added a comment.

In D70709#1767884 <https://reviews.llvm.org/D70709#1767884>, @avl wrote:

> The clang was build with -DLLVM_ENABLE_MODULES=ON and -DLLVM_USE_SPLIT_DWARF=YES, 
>  Please make me known, If it would be usefull to show results for other building options and other dsymutil
>  options.

Thanks for checking, Alexey. The modules build is good because it's kind of a special case, but I'd like to check a clang without modules as well. I'm a little confused by `LLVM_USE_SPLIT_DWARF` though, as that's not something that makes sense on macOS, unless it's a NO-OP?

Regarding the patch itself, I haven't had a look yet as there's a lot going on. Would it be possible to split this patch into the four main pieces you describe in the summary? I think that would make reviewing a lot easier.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70709/new/

https://reviews.llvm.org/D70709