[PATCH] D70910: [compiler-rt] Add a critical section when flushing gcov counters

Tue Dec 3 14:27:08 PST 2019

marco-c accepted this revision.
marco-c added a comment.

LGTM. GCC is doing the same.

After landing this, we should be able to drop the mutex we had implemented in Firefox to workaround the absence of synchronization when explicitly requesting flush (https://searchfox.org/mozilla-central/rev/8bc24752246aeac8a9aed566cf1caccf88d97d11/tools/code-coverage/CodeCoverageHandler.cpp#26-30).

I'm not so sure about the Windows 7 requirement, as this will prevent Windows Vista as a target, not just as a host. The limitation should only apply when coverage is enabled though, so I think we can live with it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70910/new/

https://reviews.llvm.org/D70910