[PATCH] D70759: [llvm-symbolizer] Support debug file lookup using build ID

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Test coverage? (since the directory can be specified, I imagine a small checked in binary example (as with other llvm-symbolizer tests) would be feasible?)



================
Comment at: llvm/lib/DebugInfo/Symbolize/Symbolize.cpp:308-315
+  if (auto *O = dyn_cast<ELFObjectFile<ELF32LE>>(Obj))
+    return getBuildID(O->getELFFile());
+  else if (auto *O = dyn_cast<ELFObjectFile<ELF32BE>>(Obj))
+    return getBuildID(O->getELFFile());
+  else if (auto *O = dyn_cast<ELFObjectFile<ELF64LE>>(Obj))
+    return getBuildID(O->getELFFile());
+  else if (auto *O = dyn_cast<ELFObjectFile<ELF64BE>>(Obj))
----------------
Avoid else-after-return: https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70759/new/

https://reviews.llvm.org/D70759