[PATCH] D70758: [PowerPC][NFC] Rename record instructions to use _record suffix instead of o
Justin Hibbits via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 3 11:29:08 PST 2019
jhibbits added a comment.
I personally think the status quo is easy to read. The definitions look like the instructions themselves, and the added verbosity seems very unnecessary. I don't know about others, but I consider people working in the PPCInstr*.td files to be either knowing exactly what they're looking for (grepping), or have a sufficient handle on the ISA that the existing notation is clear. At most I could see changing the 'o' suffix to '_o', which might help newcomers familiar with '_' notation to indicate a diminutive or subscript, but '_record' is very verbose, and as @nemanjai points out, can make some text very ugly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70758/new/
https://reviews.llvm.org/D70758
More information about the llvm-commits
mailing list