[PATCH] D70620: [CommandLine] Add callbacks to Options

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/include/llvm/Support/CommandLine.h:1430
+  void setCallback(
+      std::function<void(const typename ParserClass::parser_data_type *)> CB) {
+    Callback = CB;
----------------
Does this need to be a pointer or can it be a reference? Const reference passing seems preferable to const pointers to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70620/new/

https://reviews.llvm.org/D70620