[PATCH] D70665: [llvm-readobj] - Implement --dependent-lib-directives flag.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 3 11:01:22 PST 2019
MaskRay added a comment.
The code change looks good.
================
Comment at: llvm/docs/CommandGuide/llvm-readobj.rst:157
+
+ Display the dependent libraries section.
+
----------------
jhenderson wrote:
> section -> directives (in case it starts getting used by COFF)
@bd1976llvm @jhenderson Do we have to call it `-directives`? A `#pragma` is referred to as a directive, but the section is not.
We support other options that dump extension sections (e.g. `--stack-sizes`). None has the suffix `-directives`. I think `--dependent-libs` (I presume you will prefer the plural form) should be fine.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70665/new/
https://reviews.llvm.org/D70665
More information about the llvm-commits
mailing list