[PATCH] D70959: [ELF] Support for PT_GNU_PROPERTY in program headers and tools

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In the description, we can briefly mention that PT_GNU_PROPERTY was introduced because old linkers just "concatenate all input .note.gnu.property sections into one output .note.gnu.property section without merging them, we may see one or more NT_GNU_PROPERTY_TYPE_0 notes in PT_NOTE segment, which are invalid.".



================
Comment at: llvm/test/tools/llvm-readobj/elf-pt-gnu-property.test:1
+## Test that we can print PT_GNU_PROPERTY as GNU_PROPERTY.
+
----------------
`... as GNU_PROPERTY` is not appropriate because the LLVM style dumps the segment type as PT_GNU_PROPERTY.

We probably don't even need a comment because the test is simple enough.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70959/new/

https://reviews.llvm.org/D70959