[PATCH] D70962: [LLD][ELF] .note.gnu.property sections should have wordsize alignment

Tue Dec 3 10:42:44 PST 2019

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.

================
Comment at: lld/test/ELF/gnu-property-align.s:34
+
+.long 0xc0000002 # GNU_PROPERTY_X86_FEATURE_1_AND
+.long 4
----------------
MaskRay wrote:
> There is no `GNU_PROPERTY_X86_FEATURE_1_AND`...
> 
> @grimar I don't mind keeping this as `REQUIRES: aarch64`. I think an aarch64 test for 64-bit and an x86 test for 32-bit should be sufficient.
Sorry, GNU_PROPERTY_X86_FEATURE_1_AND exists. This looks fine.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70962/new/

https://reviews.llvm.org/D70962