[PATCH] D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFoldOperands.cpp:437
+    const MCOperandInfo &OpInfo = InstDesc.OpInfo[OpNo];
+    const SIRegisterInfo &TRI = TII->getRegisterInfo();
+
----------------
dstuttard wrote:
> arsenm wrote:
> > TRI is already a class member
> I couldn't work out if you were objecting to the name "TRI" or if you wanted me to re-use TRI from the class object.
> I decided to rename it to SRI since to re-use TRI requires a more pervasive change and an extra cast as well.
I mean re-use. I'm surprised a non-target reference to TRI exists anywhere in this pass


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70896/new/

https://reviews.llvm.org/D70896