[PATCH] D70852: [InstCombine] Guard maxnum/minnum conversions with a TTI query

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 08:14:14 PST 2019


uweigand added a comment.

Indeed, it looks like this will work; thanks for the suggestion!

However, I still think that this should be done by default in common code; if targets prefer something else they can always override it, but the default behavior of common code should be to **not** create dependencies on libm out of thin air ...

I've now implemented this as D70965 <https://reviews.llvm.org/D70965>, and it seems to work for me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70852/new/

https://reviews.llvm.org/D70852





More information about the llvm-commits mailing list