[PATCH] D70705: [DebugInfo]Support for debug_macinfo.dwo section in llvm and llvm-dwarfdump.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

This looks to be missing test coverage - this one patch adds both parsing and emission support for macinfo.dwo, but only tests the parsing support (there's no llc test that tests the emission)

Please separate patches like this into, first, a parsing patch (adds libDebugInfoDWARF functionality and test(s) like the one you have here) and then in a separate patch the emission support & tests for that.

(to be fair, I'm sort of OK (& have done myself in the past) with /only/ testing the emission, and getting test coverage for the parsing as a consequence of the emission testing, without separate parsing test coverage - but the opposite (only testing the parsing, without the emission) isn't sufficient)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70705/new/

https://reviews.llvm.org/D70705