[PATCH] D70956: [yaml2obj] - Make DynamicSymbols to be Optional<> too.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:574
+    if (HasSymbolsDescription) {
+      StringRef PropName = (IsStatic ? "`Symbols`" : "`DynamicSymbols`");
+      if (RawSec->Content)
----------------
Maybe `PropName` -> `Property`?


================
Comment at: llvm/test/tools/yaml2obj/ELF/symtab-implicit-sections-size-content.yaml:30
 # RUN: not yaml2obj --docnum=2 %s -o %t2 2>&1 | FileCheck %s --check-prefix=CASE2
+# RUN: not yaml2obj --docnum=3 %s -o %t2 2>&1 | FileCheck %s --check-prefix=CASE2
 
----------------
It probably doesn't matter much, but do the changes in this test belong with this patch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70956/new/

https://reviews.llvm.org/D70956