[PATCH] D70665: [llvm-readobj] - Implement --dependent-lib-directives flag.

Tue Dec 3 06:13:21 PST 2019

grimar added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/elf-dependent-libraries.test:36
+# MIX-NEXT:   abc
+# MIX-EMPTY:
+# MIX-NEXT:   warning: '[[FILE]]': SHT_LLVM_DEPENDENT_LIBRARIES section at index 4 is broken: section [index 4] has a sh_offset (0xffff0000) + sh_size (0x4) that cannot be represented
----------------
jhenderson wrote:
> Is there a clean way of not having this empty line? I'm not sure there's any benefit to it. It's not a big deal though if it makes the code significantly more complex.
So, the reason is more global and described here:
https://reviews.llvm.org/D70826#inline-639055

I am going to investigate how can we fix this soon.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70665/new/

https://reviews.llvm.org/D70665