[PATCH] D70913: [FPEnv][SelectionDAG] Relax chain requirements

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 06:13:21 PST 2019


uweigand marked 2 inline comments as done.
uweigand added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:3181
+        SDNode *NS = NodeStack[i].getNode();
+        for (auto UI = NS->use_begin(), UE = NS->use_end(); UI != UE; ++UI)
+          if (UI.getUse().getValueType() != MVT::Other)
----------------
craig.topper wrote:
> Can we break this loop when NonChainUses is greater than 1? No need to keep scanning.
Sure, makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70913/new/

https://reviews.llvm.org/D70913





More information about the llvm-commits mailing list