[PATCH] D63973: [MachineVerifier] Improve checks of target instructions operands.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 01:46:44 PST 2019


fhahn added a comment.

In D63973#1766594 <https://reviews.llvm.org/D63973#1766594>, @jonpa wrote:

> Thanks for review! Committed as 4fd8f11 <https://reviews.llvm.org/rG4fd8f11901b5bfb13a5fef597626dde31835873b>.
>
> @fhahn: I tried to follow your suggestions and added your comment to the existing one - please take a look...
>  (I also changed comment character from # to ; in SPARC test case, which seemed to work better)


Looks great, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63973/new/

https://reviews.llvm.org/D63973





More information about the llvm-commits mailing list